Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: backwards compatibility with v3 #40

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Nov 15, 2024

Description

Makes the module backwards compatible with v3 to avoid a breaking change for customers.

Also fixes a lock dependency issue on destroy.

Type of Change

  • Non-module change (e.g. CI/CD, documentation, etc.)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates.
    • Breaking changes.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I did run all pre-commit checks

terraform.tf Outdated
@@ -3,7 +3,7 @@ terraform {
required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = "~> 4.0"
version = ">= 3.117.0, <5.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is compatible from version 3.112.0

@jaredfholgate jaredfholgate merged commit 3857858 into main Nov 15, 2024
11 checks passed
@adammontlake adammontlake deleted the chore-backwards-compatibility-with-azurerm-v3 branch November 18, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants