Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reestructured outputs to avoid name conflicts in map keys #60

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

bryansan-msft
Copy link
Contributor

@bryansan-msft bryansan-msft commented Oct 14, 2024

Description

Fixes #58

Type of Change

  • Non-module change (e.g. CI/CD, documentation, etc.)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in locals.version.tf.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in locals.version.tf.json.
    • Breaking changes and I have bumped the MAJOR version in locals.version.tf.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I did run all pre-commit checks

@bryansan-msft bryansan-msft self-assigned this Oct 14, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Oct 14, 2024
@bryansan-msft
Copy link
Contributor Author

Due to lack of runners to run the e2e tests I will bypass the check. modtm new telemetry module needs to be implemented by AVM maintainers

@bryansan-msft bryansan-msft merged commit 2dbb8ea into main Oct 14, 2024
5 of 17 checks passed
@bryansan-msft bryansan-msft deleted the fix/errors_when_duplicated_names_in_outputs branch October 14, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: Duplicate object key in the map output by Terraform for examples sql
1 participant