Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG Review - Make zone required, Default to Private Endpoints #27

Merged
merged 4 commits into from
Jun 28, 2024

Conversation

terrymandin
Copy link
Contributor

Description

Fixes #24

As part of the review of the Disk AVM with the PG, the following changes were requested:

Make "Zone" a required property
Set "network_access_policy" to "Allow Private"
Set "public_network_access" to false

Type of Change

  • Non-module change (e.g. CI/CD, documentation, etc.)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in locals.version.tf.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • [x ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in locals.version.tf.json.
    • [x ] Breaking changes and I have bumped the MAJOR version in locals.version.tf.json.
    • [x ] Update to documentation

Checklist

  • [x ] I'm sure there are no other open Pull Requests for the same update/change
  • [ x] My corresponding pipelines / checks run clean and green without any errors or warnings
  • [x ] I did run all pre-commit checks

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jun 28, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Note

This label was added as per ITA06.

@terrymandin terrymandin changed the title PG Review - Make zone required PG Review - Make zone required, Default to Private Endpoints Jun 28, 2024
@terrymandin terrymandin merged commit 03c1cd0 into main Jun 28, 2024
11 checks passed
@terrymandin terrymandin deleted the review branch August 2, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]:
1 participant