Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init commit #28

Merged
merged 7 commits into from
Jul 4, 2024
Merged

Init commit #28

merged 7 commits into from
Jul 4, 2024

Conversation

lonegunmanb
Copy link
Member

Description

Type of Change

  • Non-module change (e.g. CI/CD, documentation, etc.)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in locals.version.tf.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in locals.version.tf.json.
    • Breaking changes and I have bumped the MAJOR version in locals.version.tf.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I did run all pre-commit checks

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jun 13, 2024
@mbilalamjad mbilalamjad mentioned this pull request Jul 3, 2024
Closed
@mbilalamjad mbilalamjad linked an issue Jul 4, 2024 that may be closed by this pull request
AVM-Review #34
Closed
mbilalamjad
mbilalamjad approved these changes Jul 4, 2024
View reviewed changes
Copy link

@mbilalamjad mbilalamjad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonegunmanb lonegunmanb merged commit 3ba00ee into main Jul 4, 2024
12 checks passed
@lonegunmanb lonegunmanb deleted the init branch December 25, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbilalamjad mbilalamjad mbilalamjad approved these changes

Assignees
No one assigned
Labels
Needs: Triage 🔍 Maintainers need to triage still
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AVM-Review
2 participants
@lonegunmanb @mbilalamjad