Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking] Wrap log_analytics_solution_id to an object to fix #263. #265

Merged
merged 2 commits into from
Apr 12, 2023
Merged

[Breaking] Wrap log_analytics_solution_id to an object to fix #263. #265

merged 2 commits into from
Apr 12, 2023

Conversation

lonegunmanb
Copy link
Member

Wrap log_analytics_solution_id to an object to fix #263.
This pr also added symbolic links notice in the readme.

@lonegunmanb lonegunmanb temporarily deployed to acctests October 10, 2022 09:52 Inactive
@lonegunmanb lonegunmanb force-pushed the f-263 branch 3 times, most recently from 9a69b4f to ec677b7 Compare October 18, 2022 09:09
@Azure Azure deleted a comment from github-actions bot Oct 18, 2022
@lonegunmanb lonegunmanb temporarily deployed to acctests November 1, 2022 03:22 Inactive
@github-actions
Copy link
Contributor

Potential Breaking Changes in 16eff1f:
[delete] "Variables.log_analytics_solution_id.Name" from 'log_analytics_solution_id' to ''

@lonegunmanb lonegunmanb temporarily deployed to acctests November 10, 2022 06:52 Inactive
@lonegunmanb lonegunmanb added this to the 7.0.0 milestone Mar 8, 2023
@lonegunmanb lonegunmanb mentioned this pull request Apr 10, 2023
Closed
1 task
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@lonegunmanb lonegunmanb changed the title Wrap log_analytics_solution_id to an object to fix #263. [Breaking] Wrap log_analytics_solution_id to an object to fix #263. Apr 10, 2023
@github-actions
Copy link
Contributor

Potential Breaking Changes in f48b3ad:
[delete] "Variables.log_analytics_solution_id.Name" from 'log_analytics_solution_id' to ''

lonegunmanb and others added 2 commits April 11, 2023 14:02
@lonegunmanb lonegunmanb temporarily deployed to acctests April 11, 2023 06:15 — with GitHub Actions Inactive
jiaweitao001
jiaweitao001 approved these changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚢

@jiaweitao001 jiaweitao001 merged commit 235c61c into Azure:main Apr 12, 2023
@lonegunmanb lonegunmanb deleted the f-263 branch November 21, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaweitao001 jiaweitao001 jiaweitao001 approved these changes

@zioproto zioproto Awaiting requested review from zioproto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
2 participants
@lonegunmanb @jiaweitao001