Turn monitoring on in the test code. #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zioproto
reviewed
Jun 24, 2022
| @@ -77,6 +78,7 @@ module "aks_without_monitor" { | |||
| source = "../.." | |||
| prefix = "prefix2-${random_id.prefix.hex}" | |||
| resource_group_name = azurerm_resource_group.main.name | |||
| #checkov:skip=CKV_AZURE_4:The logging is turn off for demo purpose. DO NOT DO THIS IN PRODUCTION ENVIRONMENT! | |||
There was a problem hiding this comment.
I understand this comment is used to disable a warning for www.checkov.io,
I dont know how to check if this comment is working as expected.
I understand CKV_AZURE_4 is correct and it means: Ensure Azure AKS cluster monitoring is enabled
https://docs.bridgecrew.io/docs/bc_azr_kubernetes_1
LGTM.
zioproto
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fix #200 and #183 by turning monitoring on in the test code.