Add support for disk_encryption_set_id
#195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonegunmanb
force-pushed
the
e-disk-encryption-set
branch
2 times, most recently
from
92ea27f to
b0a55d5
Compare
lonegunmanb
force-pushed
the
e-disk-encryption-set
branch
4 times, most recently
from
c6fe6db to
c699f06
Compare
test/fixture/providers.tf
Outdated
| } | ||
| curl = { | ||
| source = "anschoewe/curl" | ||
| version = "1.0.2" |
There was a problem hiding this comment.
Shall we be more flexible on version here?
test/fixture/disk_encryption_set.tf
Outdated
|
|
||
| resource "azurerm_key_vault" "des_vault" { | ||
| name = "${random_string.key_vault_prefix.result}-des-keyvault" | ||
| location = azurerm_resource_group.main.location |
|
Thanks @jiaweitao001 , would please give this pr another review? Thanks. |
jiaweitao001
approved these changes
Jul 12, 2022
Make version restriction more flexible.
lonegunmanb
force-pushed
the
e-disk-encryption-set
branch
from
7872125 to
4eb06d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch add support for
disk_encryption_set_idto harden the cluster's security and solve #194 . We've used Checkov and Tflint to scan the test code and ignore one issue by comment. This patch should partially solve #183.