Enable Role Based Access Control based on Azure AD #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any progress about this? |
volver-13
reviewed
Nov 4, 2021
jiaweitao001
approved these changes
Apr 25, 2022
|
Hello. Any news on this? I'm missing this feature in the module and it looks like the proposed solution could be very simple. |
|
Hello @nitinnbisht , thanks for you pr, this feature has been supported in #199 so I'm closing this pr now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103
Changes proposed in the pull request:
When both
var.enable_role_based_access_control&var.rbac_aad_managedare set totrue,azure_rbac_enabledis settrueas wellIts only possible to use
azure_rbac_enabledwhen Azure Active Directory integration is Managed, meaning that Azure will create/manage the Service Principal used for integration.