-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support workload profiles #45
support workload profiles #45
Conversation
Signed-off-by: David J. M. Karlsen <[email protected]>
Hi @davidkarlsen thanks for opening this pr! I've tried |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davidkarlsen , one comment.
Hm, probably there were some changes over time in the provider which messed it up. Let me taint the resource and re-create to test something, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davidkarlsen , LGTM! 🚀
@lonegunmanb thanks - can you create tags (and proper gh releases would be good too, as they give insights in what changes went in etc) |
@davidkarlsen We've just released a tag version. I'd like to add another feature support for this module then release our next tag. |
@lonegunmanb okidok, but releasing often and little is good as it gets out the features and helps adoption IMHO. |
Thanks @davidkarlsen for your advice, we didn't choose automatic release due to certain considerations. We treat breaking changes very seriously, so we'd like to manage our release process manually, and keep all breaking changes in one major version upgrade. |
syre - and that's fine - it's just that: |
Describe your changes
Support workload profiles, this is new in https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.85.0
This will also avoid continuous drift, else you'll get:
Issue number
#000
Checklist before requesting a review
CHANGELOG.md
fileThanks for your cooperation!