Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support workload profiles #45

Merged

Conversation

davidkarlsen
Copy link
Contributor

@davidkarlsen davidkarlsen commented Dec 21, 2023

Describe your changes

Support workload profiles, this is new in https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.85.0
This will also avoid continuous drift, else you'll get:

      - workload_profile_name         = "Consumption" -> null

Issue number

#000

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

Signed-off-by: David J. M. Karlsen <[email protected]>
@lonegunmanb
Copy link
Member

Hi @davidkarlsen thanks for opening this pr! I've tried v3.85.0 provider with startup example, and I found that there's no configuration drift on workload_profile_name, it always be empty string. According to the schema, this new attribute has no default value.

Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidkarlsen , one comment.

variables.tf Outdated Show resolved Hide resolved
@davidkarlsen
Copy link
Contributor Author

Hi @davidkarlsen thanks for opening this pr! I've tried v3.85.0 provider with startup example, and I found that there's no configuration drift on workload_profile_name, it always be empty string. According to the schema, this new attribute has no default value.

Hm, probably there were some changes over time in the provider which messed it up. Let me taint the resource and re-create to test something,

Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidkarlsen , LGTM! 🚀

@lonegunmanb lonegunmanb merged commit da26b86 into Azure:main Dec 22, 2023
4 checks passed
@davidkarlsen davidkarlsen deleted the feature/support-workload-profiles branch December 23, 2023 00:40
@davidkarlsen
Copy link
Contributor Author

@lonegunmanb thanks - can you create tags (and proper gh releases would be good too, as they give insights in what changes went in etc)

@lonegunmanb
Copy link
Member

@davidkarlsen We've just released a tag version. I'd like to add another feature support for this module then release our next tag.

@davidkarlsen
Copy link
Contributor Author

@lonegunmanb okidok, but releasing often and little is good as it gets out the features and helps adoption IMHO.
BTW: https://github.com/marvinpinto/action-automatic-releases can be used to automate creation of gh-releases when tagging.

@lonegunmanb
Copy link
Member

Thanks @davidkarlsen for your advice, we didn't choose automatic release due to certain considerations. We treat breaking changes very seriously, so we'd like to manage our release process manually, and keep all breaking changes in one major version upgrade.

@davidkarlsen
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants