Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precondition for var.container_app_environment_internal_load_balancer_enabled #33

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

lonegunmanb
Copy link
Member

@lonegunmanb lonegunmanb commented Nov 7, 2023

Describe your changes

It looks like the azurerm provider has introduced a new constriction on internal_load_balancer_enabled, once it has been set no matter the value, you must set infrastructure_subnet_id too or an error will be thrown. I've opened a pr in provider's repo for this issue, this pr changed the variable's default value to null to avoid the error caused by default values.


Update: since #39 has already updated the variable's default value, this pr only add a precondition block for this variable to provide a better user experience.

Issue number

#32 #40

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb lonegunmanb changed the title Change var.container_app_environment_internal_load_balancer_enabled's default value to solve issue caused by provider's new constriction Add precondition for var.container_app_environment_internal_load_balancer_enabled Dec 20, 2023
Copy link
Contributor

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jiaweitao001 jiaweitao001 merged commit 9ac8f17 into main Dec 20, 2023
4 checks passed
@lonegunmanb lonegunmanb deleted the f-32 branch September 24, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants