-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Front Door and Private Link integration due to module outputs #20
Conversation
* add default_domain to outputs to determine internal loadbalancer IP for Private Link Service integration * rename container_app_fqdn to container_app_uri and make container_app_fqdn a real FQDN The actual fqdn is in fact a URI, which can't be used as Front Door Origin, as it requires a bare FQDN.
Unfortunately the PR-check failed because it is a module with a "dubious ownership" being in use :)
|
Thanks for your pr and apology for this inconvenience. I'll try to fix this issue, thanks for reporting it to us. Terraform uses git to download Terraform module, so you saw this issue because the owner of '/src/examples/acr` is not the user you were using. I'm thinking of adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @icklsede for opening this pr, some review comments.
@@ -5,10 +5,20 @@ output "container_app_environment_id" { | |||
|
|||
output "container_app_fqdn" { | |||
description = "The FQDN of the Container App's ingress." | |||
value = { for name, container in azurerm_container_app.container_app : name => "${try(container.ingress[0].fqdn, "")}" if can(container.ingress[0].fqdn) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @icklsede thanks for opening this pr! Would you please simplify this expression to:?
value = { for name, container in azurerm_container_app.container_app : name => try(container.ingress[0].fqdn, "") if can(container.ingress[0].fqdn) }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And since you've changed the module's output, would you please update this example code to use the new output so our e2e test won't be broken? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lonegunmanb
The expression is just a copy from the URI output, I removed only the "https://" part. It will get the ingress FQDN from each container app and put it into a map with index of the container app name.
I'll send an update for the tests via squash commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @icklsede for the update, we have a typo in this pr, would you please correct it and run pr-check
check command listed in our readme file to verify the pr? Thanks!
@@ -1,3 +1,9 @@ | |||
output "app_url" { | |||
value = module.container_apps.container_app_uri | |||
} | |||
ouput "app_fqdn" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be output
here.
Describe your changes
add default_domain to outputs to determine internal loadbalancer IP for Private Link Service integration
rename container_app_fqdn to container_app_uri and make container_app_fqdn a real FQDN The actual fqdn is in fact a URI, which can't be used as Front Door Origin, as it requires a bare FQDN.
Issue number
#21
Checklist before requesting a review
CHANGELOG.md
fileThanks for your cooperation!