Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change exposed fqdn to ingress's fqdn #19

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Change exposed fqdn to ingress's fqdn #19

merged 4 commits into from
Aug 21, 2023

Conversation

lonegunmanb
Copy link
Member

Describe your changes

According to the document:

image

It seems like we'd better to output the ingress's fqdn as container app's access endpoint.

Issue number

#000

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb lonegunmanb temporarily deployed to acctests August 17, 2023 11:37 — with GitHub Actions Inactive
jiaweitao001
jiaweitao001 approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jiaweitao001 jiaweitao001 merged commit 8d660ae into Azure:main Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaweitao001 jiaweitao001 jiaweitao001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Azure Module Kanban
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lonegunmanb @jiaweitao001