Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide static IP as part of the outputs for non-custom domain support when using private VNET #16

Merged

Conversation

daconstenla
Copy link
Contributor

@daconstenla daconstenla commented Aug 4, 2023

Describe your changes

When connecting the container apps environment to a private VNET and you're not using custom domains you should configure a private DNS pointing to the ip according to the docs (link), quote:

Non-custom domains: If you don't plan to use custom domains, create a private DNS zone that resolves the Container Apps environment's default domain to the static IP address of the Container Apps environment. You can use Azure Private DNS or your own DNS server. If you use Azure Private DNS, create a Private DNS Zone named as the Container App environment’s default domain (<UNIQUE_IDENTIFIER>.<REGION_NAME>.azurecontainerapps.io), with an A record. The A record contains the name * and the static IP address of the Container Apps environment.
so when using private vnet private DNS can be configured

Issue number

There is no issue number.

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

so when using private vnet private DNS can be configured
@daconstenla daconstenla temporarily deployed to acctests August 7, 2023 05:45 — with GitHub Actions Inactive
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daconstenla for opening this pr! LGTM! 🚀

@lonegunmanb lonegunmanb merged commit 8f9d7f2 into Azure:main Aug 7, 2023
@x418 x418 deleted the output-the-ips-of-the-containers branch May 10, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants