Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add registry block to the module to enable personal repos #11

Merged
merged 7 commits into from
Jul 28, 2023
Merged

Add registry block to the module to enable personal repos #11

merged 7 commits into from
Jul 28, 2023

Conversation

jiaweitao001
Copy link
Contributor

Describe your changes

  • Add registry block to the module for repos which require username/password.

  • Fixed Dapr e2e test in example.

Issue number

#010

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@jiaweitao001 jiaweitao001 temporarily deployed to acctests July 18, 2023 07:13 — with GitHub Actions Inactive
@jiaweitao001 jiaweitao001 requested a review from lonegunmanb July 19, 2023 02:47
@jiaweitao001 jiaweitao001 temporarily deployed to acctests July 21, 2023 15:16 — with GitHub Actions Inactive
@jiaweitao001 jiaweitao001 temporarily deployed to acctests July 25, 2023 06:06 — with GitHub Actions Inactive
@jiaweitao001 jiaweitao001 temporarily deployed to acctests July 28, 2023 04:44 — with GitHub Actions Inactive
lonegunmanb
lonegunmanb approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jiaweitao001, LGTM!

@lonegunmanb lonegunmanb merged commit dbc39cc into Azure:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonegunmanb lonegunmanb lonegunmanb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Azure Module Kanban
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiaweitao001 @lonegunmanb