Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-sqlcmd to v0.12.0 #163

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Update go-sqlcmd to v0.12.0 #163

merged 2 commits into from
Feb 1, 2023

Conversation

shueybubbles
Copy link
Contributor

This version fixes several issues with batch parsing and variables

This version fixes several issues with batch parsing and variables
@shueybubbles shueybubbles temporarily deployed to Automation test January 31, 2023 15:00 — with GitHub Actions Inactive
@shueybubbles shueybubbles temporarily deployed to Automation test January 31, 2023 15:00 — with GitHub Actions Inactive
@shueybubbles shueybubbles temporarily deployed to Automation test January 31, 2023 15:00 — with GitHub Actions Inactive
@shueybubbles shueybubbles temporarily deployed to Automation test January 31, 2023 15:00 — with GitHub Actions Inactive
@shueybubbles shueybubbles temporarily deployed to Automation test January 31, 2023 15:00 — with GitHub Actions Inactive
@shueybubbles shueybubbles temporarily deployed to Automation test January 31, 2023 15:00 — with GitHub Actions Inactive
@zijchen
Copy link
Contributor

zijchen commented Jan 31, 2023

@shueybubbles Could you run npm run build and commit the main.js changes too? main.js is where the action actually runs out of so every time we change the ts files we need to build and update main.js

@shueybubbles
Copy link
Contributor Author

shueybubbles commented Jan 31, 2023

I was hoping to complete this PR completely within the github UI and not pull down bits locally :-)
Are the pre-reqs to build very complex to install?

@shueybubbles
Copy link
Contributor Author

maybe consider moving the version number out of the typescript into some config file that main.js reads so it's resilient to minor changes

@zijchen
Copy link
Contributor

zijchen commented Jan 31, 2023

I was hoping to complete this PR completely within the github UI and not pull down bits locally :-) Are the pre-reqs to build very complex to install?

You just need to have npm installed, then run npm install and npm run build from the root :)

@zijchen
Copy link
Contributor

zijchen commented Jan 31, 2023

maybe consider moving the version number out of the typescript into some config file that main.js reads so it's resilient to minor changes

That's a good idea, I added #164 to track

@shueybubbles shueybubbles temporarily deployed to Automation test January 31, 2023 17:39 — with GitHub Actions Inactive
@shueybubbles shueybubbles temporarily deployed to Automation test January 31, 2023 17:39 — with GitHub Actions Inactive
@shueybubbles shueybubbles temporarily deployed to Automation test January 31, 2023 17:39 — with GitHub Actions Inactive
@shueybubbles shueybubbles temporarily deployed to Automation test January 31, 2023 17:39 — with GitHub Actions Inactive
@shueybubbles shueybubbles temporarily deployed to Automation test January 31, 2023 17:39 — with GitHub Actions Inactive
@shueybubbles shueybubbles temporarily deployed to Automation test January 31, 2023 17:39 — with GitHub Actions Inactive
@zijchen zijchen merged commit 2177a5b into Azure:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants