Provide dependency of sonic-config-engine on 'sonic-platform-common' … #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wheel package Signed-off-by: Sangita Maity <[email protected]>
This was referenced Dec 15, 2019
Merged
jleveque
reviewed
Dec 17, 2019
jleveque
approved these changes
Jan 30, 2020
|
Retest vsimage please |
1 similar comment
|
Retest vsimage please |
jleveque
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Jun 11, 2020
Signed-off-by: Sangita Maity <[email protected]> > This PR is dependent on [sonic-platform-common/pull/72](sonic-net/sonic-platform-common#72) All three PRs are necessary to run `show interfaces transceiver` command. 1. [sonic-net/sonic-buildimage#3912](sonic-net/sonic-buildimage#3912) 2. [sonic-net/sonic-platform-common#72](sonic-net/sonic-platform-common#72) 3. [#767](#767) **- What I did** Add support of platform.json in sfputil to get correct output of `show interfaces transceiver` **- How to verify it** Check whether all the below-mentioned CLI's are working correctly. ``` Usage: show interfaces transceiver [OPTIONS] COMMAND [ARGS]... Show SFP Transceiver information Options: -?, -h, --help Show this message and exit. Commands: eeprom Show interface transceiver EEPROM information lpmode Show interface transceiver low-power mode status presence Show interface transceiver presence ```
abdosi
pushed a commit
to abdosi/sonic-utilities
that referenced
this pull request
Aug 4, 2020
Signed-off-by: Sangita Maity <[email protected]> > This PR is dependent on [sonic-platform-common/pull/72](sonic-net/sonic-platform-common#72) All three PRs are necessary to run `show interfaces transceiver` command. 1. [sonic-net/sonic-buildimage#3912](sonic-net/sonic-buildimage#3912) 2. [sonic-net/sonic-platform-common#72](sonic-net/sonic-platform-common#72) 3. [sonic-net#767](sonic-net#767) **- What I did** Add support of platform.json in sfputil to get correct output of `show interfaces transceiver` **- How to verify it** Check whether all the below-mentioned CLI's are working correctly. ``` Usage: show interfaces transceiver [OPTIONS] COMMAND [ARGS]... Show SFP Transceiver information Options: -?, -h, --help Show this message and exit. Commands: eeprom Show interface transceiver EEPROM information lpmode Show interface transceiver low-power mode status presence Show interface transceiver presence ```
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
Signed-off-by: Sangita Maity <[email protected]> > This PR is dependent on [sonic-platform-common/pull/72](sonic-net/sonic-platform-common#72) All three PRs are necessary to run `show interfaces transceiver` command. 1. [sonic-net/sonic-buildimage#3912](sonic-net/sonic-buildimage#3912) 2. [sonic-net/sonic-platform-common#72](sonic-net/sonic-platform-common#72) 3. [sonic-net/sonic-utilities#767](sonic-net/sonic-utilities#767) **- What I did** Add support of platform.json in sfputil to get correct output of `show interfaces transceiver` **- How to verify it** Check whether all the below-mentioned CLI's are working correctly. ``` Usage: show interfaces transceiver [OPTIONS] COMMAND [ARGS]... Show SFP Transceiver information Options: -?, -h, --help Show this message and exit. Commands: eeprom Show interface transceiver EEPROM information lpmode Show interface transceiver low-power mode status presence Show interface transceiver presence ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…wheel package
Signed-off-by: Sangita Maity [email protected]
This PR is needed by sonic-platform-common PR and sonic-utilities PR.
All three PRs are necessary to run the below command.
- What I did
Provide dependency of
sonic-config-engineonsonic-platform-commonwheel package.- How I did it
added rules in
rules/sonic-platform-common.mk- How to verify it