Upgrade windows-rs to version 0.57 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youyuanwu
force-pushed
the
windows-rs-0.57-upgrade
branch
from
1c2d757 to
c6fe207
Compare
jrahman
approved these changes
Jun 28, 2024
rsajwani
approved these changes
Jun 28, 2024
rsajwani
approved these changes
Jun 28, 2024
youyuanwu
force-pushed
the
windows-rs-0.57-upgrade
branch
from
c6fe207 to
c5ad9d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windows-rs version 0.57 has various improvements for generated com bindings and the code size reduces.
We have been using win-bindgen with config=package, which is not publicly supported, and we are advised to switch to config=implement that is supported external to windows-rs. See microsoft/windows-rs#3100 for details.
The generated code are reorganized due to the generation config mode, and the mod structures are remapped so that there is no unwanted nesting of mods, for example, FabricRuntime is no longer inside FabricCommon but they are siblings now. The generation of the code and remapping of the mods are still hacky, and we still need Azure/service-fabric-metadata#1 to improve this.
Previously all mods are generated once, but now, each mod like FabricCommon and FabricRuntime is generated separately from the winmd file per pass. The generation speed maybe slowed but in practice it is not observable.
This upgrade will cause break in down stream because of the mod layout change. But it is easy to fix: just change the imports(use) with different path.