Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: terraform private link support #991

Merged
merged 6 commits into from
Oct 15, 2024
Merged

fix: terraform private link support #991

merged 6 commits into from
Oct 15, 2024

Conversation

bragi92
Copy link
Member

@bragi92 bragi92 commented Oct 11, 2024

PR Description

New Feature Checklist

  • List telemetry added about the feature.
  • Link to the one-pager about the feature.
  • List any tasks necessary for release (3P docs, AKS RP chart changes, etc.) after merging the PR.
  • Attach results of scale and perf testing.

Tests Checklist

  • Have end-to-end Ginkgo tests been run on your cluster and passed? To bootstrap your cluster to run the tests, follow these instructions.
    • Labels used when running the tests on your cluster:
      • operator
      • windows
      • arm64
      • arc-extension
      • fips
  • Have new tests been added? For features, have tests been added for this feature? For fixes, is there a test that could have caught this issue and could validate that the fix works?

@bragi92 bragi92 marked this pull request as ready for review October 11, 2024 21:57
@bragi92 bragi92 requested a review from a team as a code owner October 11, 2024 21:57
@bragi92
Copy link
Member Author

bragi92 commented Oct 11, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bragi92
Copy link
Member Author

bragi92 commented Oct 14, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bragi92
Copy link
Member Author

bragi92 commented Oct 15, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bragi92
Copy link
Member Author

bragi92 commented Oct 15, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bragi92 bragi92 enabled auto-merge (squash) October 15, 2024 21:03
@bragi92 bragi92 merged commit cd82b25 into main Oct 15, 2024
18 checks passed
@bragi92 bragi92 deleted the kaveesh/tf_pvt_link branch October 28, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants