Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add single quotes to pod annotations for multiple namespace scenario #927

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

bragi92
Copy link
Member

@bragi92 bragi92 commented Jun 26, 2024

Full issue description can be found here

Essentially if you have the following in the configmap
podannotationnamespaceregex = "gegc|gegd"

Then the pipe is being read as a command separator by the shell script here and its unable to set the values throwing an error ->

/root/.bashrc: line 9: gegd: command not found

We can fix this by making the value a string and adding quotes around it as done in this PR.

PR Description

New Feature Checklist

  • List telemetry added about the feature.
  • Link to the one-pager about the feature.
  • List any tasks necessary for release (3P docs, AKS RP chart changes, etc.) after merging the PR.
  • Attach results of scale and perf testing.

Tests Checklist

  • Have end-to-end Ginkgo tests been run on your cluster and passed? To bootstrap your cluster to run the tests, follow these instructions.
    • Labels used when running the tests on your cluster:
      • operator
      • windows
      • arm64
      • arc-extension
      • fips
  • Have new tests been added? For features, have tests been added for this feature? For fixes, is there a test that could have caught this issue and could validate that the fix works?

@bragi92 bragi92 requested a review from a team as a code owner June 26, 2024 21:01
@bragi92 bragi92 merged commit eabe067 into main Jul 3, 2024
18 checks passed
@bragi92 bragi92 deleted the kaveesh/fix_pod_annotations branch October 28, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants