Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Upgrade ksm to 2.12.0
I have upgraded chart using backdoor deployment and found no issues , this is build link : https://github-private.visualstudio.com/azure/_build/results?buildId=80951&view=logs&s=6884a131-87da-5381-61f3-d7acc3b91d76.
I have compared between old and new KSM chart versions of helm charts for the charts we use(deployment,role,service,etc) and found no major changes between the old and new. Mainly the changes are in the parameterizing some properties based on some properties in values.yaml, but we do not have those properties in our values-template.yaml in our addon chart , so we are good there. Here are the comparison of K-S-M charts.
Screenshots of metrics flowing after upgrade:
This change was tested using following mechanism.
The annotations are flowing before and after the upgrade(below screenshot). The metrics are flowing fine and upgrade was successful.
Change:
If the annotation or label has no configured allowed values (--metric-annotations-allowlist, --metric-labels-allowlist) no object_annotations or object_labels metrics should be created.
For our testing, no change was made in either flags (--metric-annotations-allowlist, --metric-labels-allowlist) and upgraded chart was deployed. The default labels and annotations stopped flowing after the upgrade.
Before upgrade:
After upgrade:
New Feature Checklist
Tests Checklist
operator
windows
arm64
arc-extension
fips
/tests
) added?