Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: add Windows tests for Prometheus Target UX #839

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Test: add Windows tests for Prometheus Target UX #839

merged 4 commits into from
Apr 19, 2024

Conversation

gracewehner
Copy link
Contributor

@gracewehner gracewehner commented Apr 17, 2024 •
edited
Loading

PR Description

Add windows tests for the Prom UI to have parity with linux

Tests Checklist

  • Have end-to-end Ginkgo tests been run on your cluster and passed? To bootstrap your cluster to run the tests, follow these instructions.
    • Labels used when running the tests on your cluster:
      • operator
      • windows
      • arm64
      • arc-extension
  • Have new tests been added? For features, have tests been added for this feature? For fixes, is there a test that could have caught this issue and could validate that the fix works?

@gracewehner gracewehner requested a review from a team as a code owner April 17, 2024 23:54
@gracewehner gracewehner enabled auto-merge (squash) April 19, 2024 20:28
@gracewehner gracewehner merged commit 33e88af into main Apr 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashmichandrashekar rashmichandrashekar rashmichandrashekar approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gracewehner @rashmichandrashekar