Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Better cross file reference support for OAI2 -> OAI3 Converter #131

Merged
merged 23 commits into from
Dec 11, 2020
Merged

Feature: Better cross file reference support for OAI2 -> OAI3 Converter #131

merged 23 commits into from
Dec 11, 2020

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Dec 10, 2020 •
edited
Loading

@timotheeguerin timotheeguerin changed the title Feature: Better cross file reference support for OAI2 -> OAI3 Converter [WIP] Feature: Better cross file reference support for OAI2 -> OAI3 Converter Dec 10, 2020
@timotheeguerin timotheeguerin mentioned this pull request Dec 11, 2020
Closed
11 tasks
@timotheeguerin timotheeguerin changed the title [WIP] Feature: Better cross file reference support for OAI2 -> OAI3 Converter Feature: Better cross file reference support for OAI2 -> OAI3 Converter Dec 11, 2020
daviwil
daviwil approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@daviwil daviwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking time to improve the overall quality of the code, this looks great!

@timotheeguerin timotheeguerin merged commit f994a71 into master Dec 11, 2020
@timotheeguerin timotheeguerin deleted the feature/cross-refs branch December 11, 2020 19:12
@timotheeguerin timotheeguerin mentioned this pull request Dec 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviwil daviwil daviwil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$ref to original location not found in new refs collection
2 participants
@timotheeguerin @daviwil