Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Enhancements for MLZ & AVD #905

Merged
merged 2 commits into from
Feb 23, 2024
Merged

UI Enhancements for MLZ & AVD #905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4db7252
Added warning banner for firewall SKU
jamasten Feb 22, 2024
3b08239
Added description, Updated labels & tool tips for clarity
jamasten Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/bicep/add-ons/azureVirtualDesktop/uiDefinition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,18 @@
"label": "Assignment",
"visible": true,
"elements": [
{
"name": "description",
"type": "Microsoft.Common.TextBlock",
"visible": true,
"options": {
"text": "To access Azure Virtual Desktop, your end users will need to be assigned to the Desktop Applicaiton Group and if applicable, be given permissions on the storage service for FSLogix. Select the desired security groups below to give access to this AVD stamp. If deploying FSLogix, storage will be deployed for each group to support sharding. Be sure your groups are sized appropriately for each shard.",
"link": {
"label": "Learn more about FSLogix storage options for sizing your groups.",
"uri": "https://learn.microsoft.com/azure/virtual-desktop/store-fslogix-profile"
}
}
},
{
"name": "groupsApi",
"type": "Microsoft.Solutions.GraphApiControl",
Expand All @@ -455,7 +467,7 @@
{
"name": "groupsGrid",
"type": "Microsoft.Common.EditableGrid",
"ariaLabel": "Enter the security groups for access to AVD and if applicable, FSLogix. If deploying FSLogix, a storage account will be deployed for each group to support sharding.",
"ariaLabel": "Input the security groups for access to AVD and if applicable, FSLogix. The object ID is a property on the group and can be found in Entra ID.",
"label": "Security Groups",
"visible": "[empty(steps('controlPlane').assignment.groupsApi)]",
"constraints": {
Expand Down Expand Up @@ -508,7 +520,7 @@
"name": "custom",
"type": "Microsoft.Common.CheckBox",
"visible": true,
"label": "Customize friendly names for AVD Client?",
"label": "Custom friendly names?",
"defaultValue": false,
"toolTip": "Choose whether to add custom names to the AVD feed workspace and the desktop for the AVD client."
},
Expand All @@ -518,7 +530,7 @@
"label": "Feed Workspace",
"defaultValue": "",
"placeholder": "Example: Information Technology",
"toolTip": "Input the friendly name for the AVD workspace / identifier that will be displayed in the end user's client. This value should apply to all the stamp indexes within the same identifier.",
"toolTip": "Input the friendly name for the AVD workspace that will be displayed in the end user's client. This value should apply to all the stamp indexes within the same identifier and would mostly likely represent your business unit or project.",
"visible": "[steps('controlPlane').friendlyNames.custom]",
"constraints": {
"required": false,
Expand All @@ -532,7 +544,7 @@
"label": "Desktop",
"defaultValue": "",
"placeholder": "Example: Help Desk",
"toolTip": "Input the friendly name for the AVD Session Desktop application that will be displayed in the end user's client.",
"toolTip": "Input the friendly name for the AVD Session Desktop application that will be displayed in the end user's client. This value should represent the workload (eg., Help Desk, Development, or Administration) that will be supported on the host pool.",
"visible": "[steps('controlPlane').friendlyNames.custom]",
"constraints": {
"required": false,
Expand Down
8 changes: 8 additions & 0 deletions src/bicep/form/mlz.portal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,14 @@
"required": true
},
"visible": true
},
{
"name": "firewallSkuDescription",
"type": "Microsoft.Common.InfoBox",
"options": {
"style": "Warning",
"text": "Please validate the SKU availability in your region before deploying as there can be differences between clouds."
}
}
]
},
Expand Down