Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defender fix #802

Merged
merged 4 commits into from
Jan 16, 2024
Merged

defender fix #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b2ddeb
fix
Jan 16, 2024
030c3fa
test fix
Jan 16, 2024
5daac54
json update
Jan 16, 2024
0a8a7ad
GitHub Action: Build Bicep to JSON
invalid-email-address Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ You must have [Owner RBAC permissions](https://docs.microsoft.com/en-us/azure/ro

| Azure Commercial | Azure Government |
| :--- | :--- |
| [![Deploy to Azure](https://aka.ms/deploytoazurebutton)](https://portal.azure.com/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2FAzure%2Fmissionlz%2Fmain%2Fsrc%2Fbicep%2Fmlz.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2FAzure%2Fmissionlz%2Fmain%2Fsrc%2Fbicep%2Fform%2Fmlz.portal.json) | [![Deploy to Azure Gov](https://aka.ms/deploytoazuregovbutton)](https://portal.azure.us/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2FAzure%2Fmissionlz%2Fmain%2Fsrc%2Fbicep%2Fmlz.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2FAzure%2Fmissionlz%2Fmain%2Fsrc%2Fbicep%2Fform%2Fmlz.portal.json) |
| [![Deploy to Azure](https://aka.ms/deploytoazurebutton)](https://portal.azure.com/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2FAzure%2Fmissionlz%2Fmain%2Fsrc%2Fbicep%2Fmlz.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2FAzure%2Fmissionlz%2Fmain%2Fsrc%2Fbicep%2Fform%2Fmlz.portal.json) | [![Deploy to Azure Gov](https://aka.ms/deploytoazuregovbutton)](https://portal.azure.us/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2FAzure%2Fmissionlz%2Fdzikowski-defenderfix%2Fsrc%2Fbicep%2Fmlz.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2FAzure%2Fmissionlz%2Fdzikowski-defenderfix%2Fsrc%2Fbicep%2Fform%2Fmlz.portal.json) |
<!-- markdownlint-enable MD013 -->

2. After a successful deployment, see our [examples](./src/bicep/examples/README.md) directory for how to extend the capabilities of Mission Landing Zone.
Expand Down
10 changes: 5 additions & 5 deletions src/bicep/mlz.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"_generator": {
"name": "bicep",
"version": "0.10.61.36676",
"templateHash": "4961315915169693062"
"templateHash": "11325591247187477175"
}
},
"parameters": {
Expand Down Expand Up @@ -7140,7 +7140,7 @@
"_generator": {
"name": "bicep",
"version": "0.10.61.36676",
"templateHash": "16303325944519685702"
"templateHash": "9863600299947422102"
}
},
"parameters": {
Expand Down Expand Up @@ -7221,7 +7221,7 @@
"condition": "[not(empty(parameters('emailSecurityContact')))]",
"type": "Microsoft.Security/securityContacts",
"apiVersion": "2020-01-01-preview",
"name": "securityNotifications",
"name": "default",
"properties": {
"notificationsByRole": {
"roles": [
Expand Down Expand Up @@ -7291,7 +7291,7 @@
"_generator": {
"name": "bicep",
"version": "0.10.61.36676",
"templateHash": "16303325944519685702"
"templateHash": "9863600299947422102"
}
},
"parameters": {
Expand Down Expand Up @@ -7372,7 +7372,7 @@
"condition": "[not(empty(parameters('emailSecurityContact')))]",
"type": "Microsoft.Security/securityContacts",
"apiVersion": "2020-01-01-preview",
"name": "securityNotifications",
"name": "default",
"properties": {
"notificationsByRole": {
"roles": [
Expand Down
2 changes: 1 addition & 1 deletion src/bicep/modules/defender.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ resource securityWorkspaceSettings 'Microsoft.Security/workspaceSettings@2019-01
}

resource securityNotifications 'Microsoft.Security/securityContacts@2020-01-01-preview' = if (!empty(emailSecurityContact)) {
name: 'securityNotifications'
name: 'default'
properties: {
notificationsByRole: {
roles: [
Expand Down