Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key Vault private endpoint, private dns integration and diagnostic settings #750

Merged
merged 6 commits into from
Sep 12, 2022
Merged

Conversation

FabienGilbert
Copy link
Contributor

Description

Added diagnostics settings configuration, private endpoint and private DNS integration.

Issue reference

The issue this PR will close: #749

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@FabienGilbert FabienGilbert requested a review from a team as a code owner September 12, 2022 17:21
@lisamurphy-msft lisamurphy-msft added core New feature or request examples Related to content in the `src/bicep/examples` folder bug Something isn't working labels Sep 12, 2022
@lisamurphy-msft
Copy link
Contributor

@FabienGilbert thank you for your due diligence in updating the example for key-vault and adding in new integration pieces.
This is very well done and the diagram you created for this example is very succinct and understandable.

@lisamurphy-msft lisamurphy-msft enabled auto-merge (squash) September 12, 2022 21:59
@lisamurphy-msft lisamurphy-msft merged commit d739c85 into Azure:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core New feature or request examples Related to content in the `src/bicep/examples` folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key Vault example missing diagnostic settings and private endpoint
2 participants