Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tier3.bicep Creation in correct Subscription #726

Conversation

LManning-Dev
Copy link
Contributor

@LManning-Dev LManning-Dev commented Jul 19, 2022

Tier3s don't get created in the target subscription. Instead, they get created the -currently logged on- subscription. This update will correct that and close issue #724

Description

Please explain the changes you've made
I added a reference to the tier 3 subscription in the resource group creation so it doesn't get created in whatever subscription I am currently using in my context. I then updated other references to also point to the tier 3 subscription.

Issue reference

The issue this PR will close: #724

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

Tier3s don't get created in the target subscription. Instead, they get created the -currently logged on- subscription. This update will correct that and close issue Azure#724
@LManning-Dev LManning-Dev requested a review from a team as a code owner July 19, 2022 03:27
Copy link
Contributor

@lisamurphy-msft lisamurphy-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing a simple PR that provides a more logical deployment strategy for Tier3 resources. Testing returned successful. Approving.

@lisamurphy-msft lisamurphy-msft merged commit 33a21d1 into Azure:main Aug 29, 2022
@lisamurphy-msft lisamurphy-msft added the core New feature or request label Sep 8, 2022
jwaltireland pushed a commit to ARPA-H/AzureMissionLZ that referenced this pull request Nov 14, 2024
Tier3s don't get created in the target subscription. Instead, they get created the -currently logged on- subscription. This update will correct that and close issue Azure#724

Co-authored-by: lisamurphy-msft <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tier 3 Creates the Resource Group in the wrong subscription
2 participants