Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce a mandatory resourcePrefix parameter #554

Closed
wants to merge 4 commits into from

Conversation

glennmusa
Copy link
Contributor

Description

This change:

  • makes resourcePrefix a mandatory parameter
  • removes deployment().name as a seed for resource names and uniqueness
  • uses resourcePrefix for resource names
  • uses resourcePrefix + utcNow() to generates uniqueness
  • updates Azure DevOps pipelines to ensure a resourcePrefix parameter is supplied to deployment commands
  • updates documentation to inform users that this parameter is now mandatory and used for naming

Issue reference

The issue this PR will close: #552

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@glennmusa
Copy link
Contributor Author

Was seeing if a new branch would kickoff the pipelines, doesn't appear so. Closing.

@glennmusa glennmusa closed this Dec 3, 2021
@glennmusa glennmusa deleted the glenn/resourcePrefixMandatory branch January 19, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require a user-supplied value for resourcePrefix and do not use deployment().name for seeding names
1 participant