-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified tags to support add values and removing default #537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense 👍. Have a nit regarding the variable name and wonder if the policy change should be in another merge.
Some more Boy Scouting, I noticed the hub resource group is missing a tags
assignment. Can we update that in this change too?
Lines 8 to 15 in 9a3529b
module hubResourceGroup './modules/resourceGroup.bicep' = { | |
name: 'deploy-rg-hub-${nowUtc}' | |
scope: subscription(hubSubscriptionId) | |
params: { | |
name: hubResourceGroupName | |
location: hubLocation | |
} | |
} |
src/bicep/modules/policies/CMMC-policyAssignmentParameters.json
Outdated
Show resolved
Hide resolved
…om/Azure/missionlz into shawng/modify-tags-to-keep-default
…om/Azure/missionlz into shawng/modify-tags-to-keep-default
Description
Added the ability to use the
tags
parameter to add additional tags but not lose the default tags. Customers can still use something liketags='{"Owner":"Contoso","Cost Center":"2345-324"}'
in bash to create a tag object then deploy with parameters like--parameters resourcePrefix="mlz-prod" deployASC="true" deployPolicy=true policy="CMMC" tags="$tags"
which will not replace the current default use of prefix and deployment type tags.Issue reference
The issue this PR will close: #530
Checklist
Please make sure you've completed the relevant tasks for this PR out of the following list: