modified private link naming variables #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennmusa
reviewed
Nov 17, 2021
Co-authored-by: Glenn Musa <[email protected]>
glennmusa
approved these changes
Nov 18, 2021
jwaltireland
pushed a commit
to ARPA-H/AzureMissionLZ
that referenced
this pull request
Nov 14, 2024
* modified private link naming variables * GitHub Action: Build Bicep to JSON * Update src/bicep/modules/privateLink.bicep Co-authored-by: Glenn Musa <[email protected]> * removed space in dns declaration * GitHub Action: Build Bicep to JSON Co-authored-by: github-actions <[email protected]> Co-authored-by: Glenn Musa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During testing it was discovered that longer than normal prefix naming could cause private link scoping (which was set to 16 characters) to truncate the LAWS name down to ending with a hyphen which in turn broke creating the private link scope.
Issue reference
The issue this PR will close: #527
Checklist
Please make sure you've completed the relevant tasks for this PR out of the following list: