-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use Bicep loop syntax to create spoke resources the same way #497
Conversation
Using code space, I deployed this branch but it had a failed deployment ""The resource operation completed with terminal provisioning state 'Failed'" - Not sure if it was as a result of the loop changes or not. It may have been a different issue. The reference is at https://portal.azure.com/#@azureglobal2.onmicrosoft.com/resource/subscriptions/2b01c398-5868-496e-a84f-503ea9eac23a/subdeployments Upon further review, it's a the privateEndpoints that had a conflict. |
Judging by the error message on the {
"status": "Failed",
"error": {
"code": "InternalServerError",
"message": "An error occurred.",
"details": []
}
} Does this occur every time you try to deploy? I have yet to encounter this error, but would love to nail down a root cause if it happens to you repeatedly. |
When I did a redeploy, from the portal, I received a different error : ""A virtual network cannot be linked to multiple zones with overlapping namespaces. You tried to link virtual network with 'privatelink.monitor.azure.com' and 'privatelink.monitor.azure.com' zones."" ... I will start a fresh deploy and advise of the deployment status. |
Deployed successfully. |
Description
This change creates spokes and their dependencies in the same way to reduce the likelihood of introducing changes that causes spokes to differ.
First, it creates a
mlz.bicep
array calledspokes
that is composed of user-defined and defaulted parameters:missionlz/src/bicep/mlz.bicep
Lines 557 to 561 in d95dc7a
Then, it uses Bicep's loop syntax to create modules for those items in the
spokes
array:missionlz/src/bicep/mlz.bicep
Lines 17 to 25 in d95dc7a
This change also adds documentation on how to retrieve deployed resources programmatically:
https://github.com/Azure/missionlz/blob/d95dc7a43a32260fe6532fab1b313c2f7cff764e/src/bicep/README.md#reference-deployment-output
Issue reference
The issue this PR will close: #493
Checklist
Please make sure you've completed the relevant tasks for this PR out of the following list: