Remove validate, update build workflows. #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennmusa
approved these changes
Oct 7, 2021
jwaltireland
pushed a commit
to ARPA-H/AzureMissionLZ
that referenced
this pull request
Nov 14, 2024
* Remove validate, update build workflows. * Remove rm, not necessary. * Linter request, change to env variable. * Remove backticks * Double quotes. * More linting issues. Co-authored-by: Bree Stryker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The validate bicep action is replaced with a validate-build action to only fire on pull_requests to the main branch and not to other protected branches. The failure to commit/build correctly was based on a detached head issue. This has been fixed with some work arounds;. The status failure to push when there isn't a difference between the mlz.json file builds, has been covered with a git status check.
To Test: Branch from this branch 'breestryker/validateactionbuildrepair' make changes to the bicep files under src/bicep and create a mock PR to main. The workflow action should fire.
Issue reference
The issue this PR will close: #426
Checklist
Please make sure you've completed the relevant tasks for this PR out of the following list: