Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added firewalls policies for AzureCloud and MSFT Login #442

Merged
merged 4 commits into from
Oct 8, 2021

Conversation

shawngib
Copy link
Member

@shawngib shawngib commented Oct 6, 2021

Description

Azure firewall blocks all internet connectivity. VMs that require access to Azure Portal or Login fail. This PR adds 'AzureCloud' tag to firewall but also adds a work around for the tags missing FQDNs which participate in logging users in,

Issue reference

The issue this PR will close: #410

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will give it a test deployment, but some initial feedback about managing the complex object that describes the rules

src/bicep/modules/firewall.bicep Show resolved Hide resolved
src/bicep/modules/firewall.bicep Show resolved Hide resolved
Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took effect for me 👍

@glennmusa
Copy link
Contributor

You'll notice when you merge latest that there'll be automation that will build mlz.bicep on your behalf

@shawngib shawngib merged commit d663cfc into main Oct 8, 2021
@shawngib shawngib deleted the shawngib/ConfigureFirewallForAAD branch October 8, 2021 12:40
jwaltireland pushed a commit to ARPA-H/AzureMissionLZ that referenced this pull request Nov 14, 2024
* added firewalls policies for AzureCloud and MSFT Login

* GitHub Action: Build Bicep to JSON

Co-authored-by: lisamurphy-msft <[email protected]>
Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure Firewall to allow authentication to AAD
3 participants