Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nightly and PR validation pipelines in Azure DevOps #437
Add nightly and PR validation pipelines in Azure DevOps #437
Changes from 61 commits
647158b
06e035a
69f534f
9d64906
4228369
75b76d8
aad6f37
e311e61
c9b2279
88fdd5b
c9a9cc4
1258e39
be5c7f7
2780f32
2aae9cc
ec033bb
20f2e94
ad6820a
4cf7d69
1f1ea00
07b6703
b2f0c39
c864f04
c7b356e
0774ae0
3aaed43
1a15d06
9f9ea25
dae982d
746c630
fd29cec
8d697d4
4aa66b9
78d3223
f156fab
367162f
2aea8b3
7148088
bb9d75f
95117e8
f7f4172
1296072
ec68421
47d2fc4
5dc010e
22bb745
a0820a8
20da94c
04b637a
4c4e615
474d47d
84aeb76
8649723
7e4dea8
c545c14
33987b6
30203d5
49f4704
0dc6625
5745d3e
7e2dac7
770d53d
80b70f5
e642406
25f253d
f5a3f7b
40f9326
d139e29
b7baa2c
1802e3c
df3588b
b5a67ea
767ff65
8ed27bb
81ad76a
d9d5d80
6d4be1c
bbb30c7
1654b9d
935d284
b9a3a3b
86780d8
caa2aa5
3f8b2c7
f30a52d
aa592b1
4335041
ad297b5
348428d
6f68d42
00aef56
8f79c54
2c9a810
877d5d5
96f9dba
ecac5b2
43eaa07
d3d3d94
1039794
0a8bdc8
5fda9a4
3d9b8a7
4390572
89e51b0
ec4bff6
362508d
51d4a74
f9f4b8f
543a2e2
2b665ad
6df8966
5660ecc
86cf9ae
e070f4a
ce68bde
fc7c9c0
06ca20b
a9aa663
6b0656c
2f6127a
008cc5d
d4272aa
f91167c
4b80aab
b591368
b151142
6e4e1ff
d976997
5c94126
ea7f2eb
3553256
4213480
71719ad
d92d480
9bdf972
33a0e9b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update the script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just set the environment variable and not echo them (sure, Pipelines is smart enough to mask the values, but there's no need to do it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm...I have removed them before PR. Will check it again as ADO is not showing them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just set the environment variable and not echo them (sure, Pipelines is smart enough to mask the values, but there's no need to do it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will check it again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These aren't GitHub workflows. Let's move this (and the other nightly deployment pipelines) into an Azure DevOps specific folder at:
./.azure-devops
:./.azure-devops/nightly/bicepAzureCloud.yml
./.azure-devops/nightly/bicepAzureUsGovernment.yml
./.azure-devops/nightly/terraformAzureCloud.yml
./.azure-devops/nightly/terraformAzureUsGovernment.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using a trigger configured in the Pipelines UI, let's describe the cron schedule in source:
https://docs.microsoft.com/en-us/azure/devops/pipelines/process/scheduled-triggers?view=azure-devops&tabs=yaml#running-even-when-there-are-no-code-changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will check that option. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This task could use a friendlier
displayName
since it's not obvious what this shell script is doing at a glance.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed