Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Terraform modules and docs #424

Merged
merged 28 commits into from
Sep 21, 2021
Merged

update Terraform modules and docs #424

merged 28 commits into from
Sep 21, 2021

Conversation

glennmusa
Copy link
Contributor

@glennmusa glennmusa commented Sep 21, 2021

Description

This change integrates the changes from /main into the long-lived feature branch /bicep so that /bicep can be merged to /main and pruned.

Issue reference

The issue this PR will is associated with #420

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@glennmusa glennmusa enabled auto-merge (squash) September 21, 2021 22:00
Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terraform and Bicep deployments work well. ❤️‍🔥

@glennmusa glennmusa merged commit c36cbb4 into bicep Sep 21, 2021
@glennmusa glennmusa deleted the reverseintegratebicep branch September 21, 2021 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants