-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkbox Render Logic Fix #218
Conversation
Does the trick 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirming: there are currently no checkboxes in the UI that default to checked, correct?
The code deploys the UI and checkboxes appear to function normally.
Yes that's correct. For testing I flipped them to ensure it worked, and then flipped them back. |
The |
Confirmed, I do see it now that it's merged to main. Thank you! |
Co-authored-by: Bree Stryker <[email protected]>
Description
Modified the checkbox logic to check for a boolean, if true will add checked=checked to the checkbox.
Additionally this sets the value of the checkbox to true, to be read in during parsing.
Correct setup still includes setting any boolean values in .orig.tfvars.json files to false. Current parser logic would not be able to see a missing value (checkbox values are simply not included in the post/get request.
Issue reference
The issue this PR will close: #213
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
shellcheck
.vscode/extensions.json
.)