Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox Render Logic Fix #218

Merged
merged 3 commits into from
May 20, 2021
Merged

Conversation

Breanna-Stryker
Copy link
Contributor

Description

Modified the checkbox logic to check for a boolean, if true will add checked=checked to the checkbox.
Additionally this sets the value of the checkbox to true, to be read in during parsing.

Correct setup still includes setting any boolean values in .orig.tfvars.json files to false. Current parser logic would not be able to see a missing value (checkbox values are simply not included in the post/get request.

Issue reference

The issue this PR will close: #213

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@glennmusa
Copy link
Contributor

Does the trick 👍

@Breanna-Stryker Breanna-Stryker merged commit b8bf333 into main May 20, 2021
@Breanna-Stryker Breanna-Stryker deleted the bree/213patchcheckboxrender branch May 20, 2021 19:11
Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirming: there are currently no checkboxes in the UI that default to checked, correct?
The code deploys the UI and checkboxes appear to function normally.

@Breanna-Stryker
Copy link
Contributor Author

Just confirming: there are currently no checkboxes in the UI that default to checked, correct?
The code deploys the UI and checkboxes appear to function normally.

Yes that's correct. For testing I flipped them to ensure it worked, and then flipped them back.

@glennmusa
Copy link
Contributor

glennmusa commented May 20, 2021

Just confirming: there are currently no checkboxes in the UI that default to checked, correct?
The code deploys the UI and checkboxes appear to function normally.

The create_bastion_jumpbox value defaults to true: https://github.com/Azure/missionlz/blob/main/src/core/saca-hub/saca-hub.front.json#L153-L159 -- but, you'd have had to merged latest into this branch to see that value

@brooke-hamilton
Copy link
Contributor

Just confirming: there are currently no checkboxes in the UI that default to checked, correct?
The code deploys the UI and checkboxes appear to function normally.

The create_bastion_jumpbox value defaults to true: https://github.com/Azure/missionlz/blob/main/src/core/saca-hub/saca-hub.front.json#L153-L159 -- but, you'd have had to merged latest into this branch to see that value

Confirmed, I do see it now that it's merged to main. Thank you!

jwaltireland pushed a commit to ARPA-H/AzureMissionLZ that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkboxes in the UI don't toggle boolean variables
3 participants