-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Forced Tunneling to the Hub Firewall configuration #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Route Table to HUB module - Added TIME provder declaration to SACA-HUB main.tf
- Added management IP config to firewall
We'll need to add the |
glennmusa
reviewed
May 11, 2021
glennmusa
reviewed
May 11, 2021
glennmusa
reviewed
May 11, 2021
glennmusa
reviewed
May 12, 2021
glennmusa
added
the
do-not-merge
This pull request is in process and should not be merged to main.
label
May 12, 2021
added the do-not-merge label for the time being until docs are up-to-date with guidance on forced tunneling @Phydeauxman -- feel free to remove it whenever |
glennmusa
approved these changes
May 13, 2021
glennmusa
removed
the
do-not-merge
This pull request is in process and should not be merged to main.
label
May 18, 2021
jwaltireland
pushed a commit
to ARPA-H/AzureMissionLZ
that referenced
this pull request
Nov 14, 2024
* - Added Management subnet to SACA Virtual Network * - Added route table to management subnet * - Added TIME provider to Docerkfile - Added Route Table to HUB module - Added TIME provder declaration to SACA-HUB main.tf * - Updated FW related variable names - Added management IP config to firewall * - Removed AZURERM provider arg for 2.50 * - Added new line at end of file * - Updated variable names in template files * - Update variable names * update global tf vars generator * - Added additional fields to the frontend json * - Added route table field to frontend json * - Updated variable names in modules * - Added missing variable to json sample Co-authored-by: Glenn Musa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables forced tunneling the firewall deployment by adding a management subnet to the hub virtual network, creating a route table applied to the management subnet with a default route to the Internet and adding a management IP config to the firewall.
Issue reference
The issue this PR will close: #117
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
shellcheck
.vscode/extensions.json
.)