Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --help option and handle unexpected arguments #182

Merged
merged 20 commits into from
Apr 29, 2021
Merged

Conversation

glennmusa
Copy link
Contributor

Description

This change makes two updates to end-user facing scripts:

  • Maps -h from --hub-sub-id to --help to print the argument list for commands that take named arguments
  • Maps -u to --hub-sub-id
  • Handles unexpected arguments
    • (e.g. if I call src/deploy.sh --foo bar I receive a ERROR: Unexpected argument --foo and the command doesn't execute)

Issue reference

The issue this PR will close: #164, #181

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@glennmusa glennmusa enabled auto-merge (squash) April 28, 2021 14:26
Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested all the affected scripts with -h and --help. It's awesome that they all have the same functionality.

@glennmusa glennmusa merged commit d9364d5 into main Apr 29, 2021
@glennmusa glennmusa deleted the glenn/addhelp branch April 29, 2021 14:18
jwaltireland pushed a commit to ARPA-H/AzureMissionLZ that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

End-user facing scripts should have a --help -h option
3 participants