Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complex Environmental Name Replacements #178

Merged
merged 8 commits into from
Apr 26, 2021
Merged

Complex Environmental Name Replacements #178

merged 8 commits into from
Apr 26, 2021

Conversation

Breanna-Stryker
Copy link
Contributor

Description

Change environmental replacement options to regex capture groups

  • Added Regex Substitution in Place of flat replace
  • Added function to iterate matching groups
  • Updated templates to match new syntax

Issue reference

The issue this PR will close: #156

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

glennmusa
glennmusa reviewed Apr 26, 2021
View reviewed changes
Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we can update -eastus- in all the *.front.json with -${env:MLZ_LOCATION}- too, right?

@glennmusa glennmusa mentioned this pull request Apr 26, 2021
Merged
6 tasks
@Breanna-Stryker
Copy link
Contributor Author

Looks like we can update -eastus- in all the *.front.json with -${env:MLZ_LOCATION}- too, right?

You're right! Done!

@Breanna-Stryker Breanna-Stryker merged commit 8919021 into main Apr 26, 2021
@Breanna-Stryker Breanna-Stryker deleted the complexenvreplace branch April 26, 2021 18:32
jwaltireland pushed a commit to ARPA-H/AzureMissionLZ that referenced this pull request Nov 14, 2024
@Breanna-Stryker
Complex Environmental Name Replacements (Azure#178)
030827a 
* Auto Scroll Text, Fix Variable Mismatches in local output.

* Add code for more complex environmental substitutes, update templates.

* Update tier-0.front.json

* Update tier-1.front.json

* Update tier-2.front.json

* Replace the Location with the appropriate env variable

Co-authored-by: Bree Stryker <[email protected]>
Co-authored-by: Bree Stryker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmusa glennmusa glennmusa approved these changes

@Phydeauxman Phydeauxman Awaiting requested review from Phydeauxman

@brooke-hamilton brooke-hamilton Awaiting requested review from brooke-hamilton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for variable input for default form values in the UI
2 participants
@Breanna-Stryker @glennmusa