-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate input for Azure Region and Terraform Environment on deploy.sh and setup_ezdeploy.sh #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Various fixes and refactor to allow for export and load * Update documentation. * Abstract export code to own file, extend to allow file names * Fix various. Co-authored-by: Bree Stryker <[email protected]>
glennmusa
requested review from
Phydeauxman,
brooke-hamilton and
Breanna-Stryker
April 23, 2021 14:04
sstjean
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks solid.
Successfully tested functionality against Commercial and Gov.
jwaltireland
pushed a commit
to ARPA-H/AzureMissionLZ
that referenced
this pull request
Nov 14, 2024
…h and setup_ezdeploy.sh (Azure#174)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today,
deploy.sh
andsetup_ezdeploy.sh
use AzureCloud-specific defaults to make it simpler for end-users to deploy. However, they A) may not know these defaults are set for them and B) these defaults may not be valid for the cloud they're deploying to.This change:
For example, if I set my cloud to AzureUsGovernment:
and try to deploy using ./deploy.sh with the defaults, I'll get back these messages and this error:
and if I provide a valid location, but do not provide a matching terraform environment:
Issue reference
The issue this PR will close: #172, #173
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
shellcheck
.vscode/extensions.json
.)