Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc changes to UI deployment and dev container getting started guides #137

Merged
merged 17 commits into from
Apr 1, 2021
Merged

Doc changes to UI deployment and dev container getting started guides #137

merged 17 commits into from
Apr 1, 2021

Conversation

bspender
Copy link
Contributor

@bspender bspender commented Mar 31, 2021 •
edited
Loading

Description

Doc changes only - added some additional formatting, links, and some 101 references for Win10/WSL

Issue reference

The issue this PR will close: # n/a

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • All tests pass (manual and automated)
  • BASH scripts have been validated using shellcheck
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@glennmusa
Copy link
Contributor

Thanks for these updates! Very helpful. I'll leave it to the assigned reviewers who are more familiar to approve.

brooke-hamilton
brooke-hamilton suggested changes Mar 31, 2021
View reviewed changes
.devcontainer/README.md Outdated Show resolved Hide resolved
.devcontainer/README.md Show resolved Hide resolved
bspender
bspender commented Apr 1, 2021
View reviewed changes
Copy link
Contributor Author

@bspender bspender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to "fix" the 1-5 [Ordered List] list near the end of this file on lines 97, 103, 130, and 152 (these were already here, but it showed up when I put the file through the linter). Is that ok?

src/docs/ui-deployment.md Show resolved Hide resolved
@bspender bspender requested a review from brooke-hamilton April 1, 2021 13:14
brooke-hamilton
brooke-hamilton approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@glennmusa glennmusa merged commit adca643 into Azure:main Apr 1, 2021
jwaltireland pushed a commit to ARPA-H/AzureMissionLZ that referenced this pull request Nov 14, 2024
@bspender
Doc changes to UI deployment and dev container getting started guides (…
c956a92 
…Azure#137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmusa glennmusa glennmusa left review comments

@brooke-hamilton brooke-hamilton brooke-hamilton approved these changes

Assignees

@brooke-hamilton brooke-hamilton

@Breanna-Stryker Breanna-Stryker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bspender @glennmusa @brooke-hamilton @Breanna-Stryker