Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] support metadata host in terraform backends #102

Closed
wants to merge 2 commits into from

Conversation

glennmusa
Copy link
Contributor

Description

Adds the metadata host value to the MLZ configuration file and maps it to terraform backends during init, apply, and destroy.

Issue reference

The issue this PR will close: #100

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@brooke-hamilton
Copy link
Contributor

Does the metadata host value have a default? I'm wondering if this is going to break the UI.

@glennmusa glennmusa changed the title support metadata host in terraform backends [do not merge] support metadata host in terraform backends Mar 23, 2021
@glennmusa
Copy link
Contributor Author

Does the metadata host value have a default? I'm wondering if this is going to break the UI.

Gonna hold off on merging until the UI is in.

@glennmusa glennmusa added the do-not-merge This pull request is in process and should not be merged to main. label Mar 23, 2021
@glennmusa
Copy link
Contributor Author

Will pick this back up after #145 merges

@glennmusa glennmusa closed this Apr 8, 2021
@glennmusa
Copy link
Contributor Author

Abandoned in favor of #147

@glennmusa glennmusa deleted the glennmusa/metadatahost branch April 8, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge This pull request is in process and should not be merged to main.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing metadata host URL on backend configurations
2 participants