-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OIDC support for sovereign clouds #258
Conversation
@arnoldna Thanks for the PR. Can you add more details on the tests that were done for this PR? |
I have access to an AzureUSGovernment subscription and tested connectivity utilizing the following yaml: `name: Run Azure Login with OpenID Connect permissions: jobs:
If there are other tests you would like to run then let me know. |
@BALAGA-GAYATRI Any updates on this PR? |
This PR is idle because it has been open for 14 days with no activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
We are following up on the same. Will get back with the info. |
@BALAGA-GAYATRI - Can we get an update on when this PR will be approved? Thanks |
This PR is idle because it has been open for 14 days with no activity. |
friendly bump on this ❤️ |
Looks like the linting is failing on README - can someone please fix this and merge? PR has been open for months |
Closing this pr, the feature is done in #321. |
switch(environment){ | ||
case 'azurecloud': | ||
resourceManagerEndpointUrl = "https://management.azure.com/"; | ||
break; | ||
case 'azureusgovernment': | ||
resourceManagerEndpointUrl = "https://management.usgovcloudapi.net/"; | ||
break; | ||
case 'azurechinacloud': | ||
resourceManagerEndpointUrl = "https://management.chinacloudapi.cn/"; | ||
break; | ||
default: | ||
resourceManagerEndpointUrl = "https://management.azure.com/"; | ||
break; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resourceManagerEndpointUrl
is in the output of az ad sp create-for-rbac --sdk-auth
and az cloud list/show
, so it shouldn't be hard-coded.
> az ad sp create-for-rbac --sdk-auth
{
"clientId": "...",
"clientSecret": "...",
"subscriptionId": "...",
"tenantId": "...",
"activeDirectoryEndpointUrl": "https://login.microsoftonline.com",
"resourceManagerEndpointUrl": "https://management.azure.com/",
"activeDirectoryGraphResourceId": "https://graph.windows.net/",
"sqlManagementEndpointUrl": "https://management.core.windows.net:8443/",
"galleryEndpointUrl": "https://gallery.azure.com/",
"managementEndpointUrl": "https://management.core.windows.net/"
}
Added OIDC support for AzureUSGovernment and AzureChinaCloud
ISSUE #257- #257