Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up download time with Webpack #194

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mayong43111
Copy link

I notice that the node_module folder is included in the tag of the publication and need it at run time, but it's very big. I modified to use Webpack to package the project, In my sel-hosted, the Set Up Job step saves 30 seconds. so I recommend using it and remove node_module from tag.

@github-actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Jan 22, 2022
@BALAGA-GAYATRI
Copy link
Contributor

Hey @mayong43111. Thanks for the contribution. I want to understand your approach better. How are you able to accomplish the performance improvement. I could see some regexes are also being used. Can you help us with that?

@mayong43111
Copy link
Author

mayong43111 commented Mar 22, 2022

Hey @mayong43111. Thanks for the contribution. I want to understand your approach better. How are you able to accomplish the performance improvement. I could see some regexes are also being used. Can you help us with that?

Hi @BALAGA-GAYATRI , thanks for your commented . Webpack can scan 'require' in code and package it into one file. But the esprima.js component uses the ‘readfilesys’ method, which Webpack cannot package. So I modified his code in a regexes way. replace it with something Webpack accepts before packaging. Of course the best way is for him to fix the code, Instead of hacking it's code.

reference:
https://stackoverflow.com/questions/61680141/webpack-bundle-with-jsonpath-dependency

@github-actions github-actions bot removed the idle Inactive for 14 days label Mar 22, 2022
@spartow
Copy link

spartow commented Mar 23, 2022

approved

@github-actions
Copy link

github-actions bot commented Apr 6, 2022

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Apr 6, 2022
@rdeveen
Copy link

rdeveen commented Mar 24, 2023

Can this PR get some love?💘

@github-actions github-actions bot removed the idle Inactive for 14 days label Mar 24, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Inactive for 14 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants