-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up download time with Webpack #194
base: master
Are you sure you want to change the base?
Conversation
This PR is idle because it has been open for 14 days with no activity. |
Hey @mayong43111. Thanks for the contribution. I want to understand your approach better. How are you able to accomplish the performance improvement. I could see some regexes are also being used. Can you help us with that? |
Hi @BALAGA-GAYATRI , thanks for your commented . Webpack can scan 'require' in code and package it into one file. But the esprima.js component uses the ‘readfilesys’ method, which Webpack cannot package. So I modified his code in a regexes way. replace it with something Webpack accepts before packaging. Of course the best way is for him to fix the code, Instead of hacking it's code. reference: |
approved |
This PR is idle because it has been open for 14 days with no activity. |
Can this PR get some love?💘 |
This PR is idle because it has been open for 14 days with no activity. |
I notice that the node_module folder is included in the tag of the publication and need it at run time, but it's very big. I modified to use Webpack to package the project, In my sel-hosted, the Set Up Job step saves 30 seconds. so I recommend using it and remove node_module from tag.