Package Size Issue with Azure Login GitHub Action

[kWozniak-tt]

Description

I've identified a significant issue with the Azure login GitHub action, where the action's package size is excessively large. After unpacking, the node_modules directory alone is 118MB. This substantial size dramatically affects the startup time of the GitHub action. It seems all dependencies, including those not needed for production, are being installed in the package. Additionally, the package contains folders like tests, src, and .github, which are unnecessary for the action's operation.


Download Link

Proposed Solution:

1. Production-Optimized Configuration: Configure the package specifically for production use, adhering to npm standards. Exclude non-production dependencies and unnecessary folders like __tests__, src, and .github to reduce the package size and improve performance.

2. Use of @vercel/ncc for Compiling Code: As an alternative to checking in the node_modules directory, which can cause issues, use the @vercel/ncc tool to compile code and modules into a single file for distribution. This approach is suggested in GitHub's documentation. After installing @vercel/ncc, compile the index.js file, resulting in a new dist/index.js file with code and compiled modules, alongside a dist/licenses.txt file containing all licenses of the used node_modules. Update the action.yml file to use dist/index.js and remove the previously checked-in node_modules directory. This solution ensures a more efficient and streamlined package, in line with best practices for GitHub actions.

[kWozniak-tt]

I have created a pull request for the second solution:
#367
I also tested it in my repository

[jharbieh-microsoft]

Thanks for pointing this out and working on this case @kWozniak-tt

[YanaXu]

@kWozniak-tt, Thanks for raising this request. It's clear and helpful. We will add it to our plan.

[jharbieh-microsoft]

[heart] Johnny Harbieh reacted to your message:

…

________________________________ From: Yan Xu ***@***.***> Sent: Thursday, November 23, 2023 2:14:16 AM To: Azure/login ***@***.***> Cc: Comment ***@***.***> Subject: Re: [Azure/login] Package Size Issue with Azure Login GitHub Action (Issue #366) @kWozniak-tt<https://github.com/kWozniak-tt>, Thanks for raising this request. It's clear and helpful. We will add it to our plan. — Reply to this email directly, view it on GitHub<#366 (comment)> or unsubscribe<https://github.com/notifications/unsubscribe-auth/ASXMBB7VZUSZMAZ7SK6FOGLYF2WPTBFKMF2HI4TJMJ2XIZLTSWBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVIZDGOBXGMZTKMRYGWSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRSGQ4DOMZQHEYDSN5ENZQW2ZNJNBQXGX3MMFRGK3FMON2WE2TFMN2F65DZOBS2YSLTON2WKQ3PNVWWK3TUUZ2G64DJMNZZJAVEOR4XAZNKOJSXA33TNF2G64TZUV3GC3DVMWUTEMJQG44TQNRRGWBKI5DZOBS2K2LTON2WLJLWMFWHKZNKGE4TQNZZGY2DOOBWQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRSGM4DOMZTGUZDQNMCUR2HS4DFUVWGCYTFNSSXMYLMOVS2UMRUHA3TGMBZGA4TPJ3UOJUWOZ3FOKTGG4TFMF2GK>. You are receiving this email because you commented on the thread. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[kWozniak-tt]

@MoChilia why this issue was unpinned

[YanaXu]

@kWozniak-tt no worries, we'll pin it again after this release. It's still on our table.