EdgeAgent: Add logs provider #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varunpuranik
commented
Mar 7, 2019
edge-agent/src/Microsoft.Azure.Devices.Edge.Agent.Docker/RuntimeInfoProvider.cs
Outdated
Show resolved
Hide resolved
varunpuranik
commented
Mar 7, 2019
edge-agent/src/Microsoft.Azure.Devices.Edge.Agent.Edgelet/RuntimeInfoProvider.cs
Outdated
Show resolved
Hide resolved
philipktlin
reviewed
Mar 7, 2019
| @@ -15,6 +17,8 @@ public interface IRuntimeInfoProvider | |||
| { | |||
| Task<IEnumerable<ModuleRuntimeInfo>> GetModules(CancellationToken ctsToken); | |||
|
|
|||
| Task<Stream> GetModuleLogs(string module, bool follow, Option<int> tail, CancellationToken cancellationToken); | |||
There was a problem hiding this comment.
nit: ctsToken, same as above.
philipktlin
reviewed
Mar 7, 2019
| @@ -40,4 +41,12 @@ | |||
| <CodeAnalysisRuleSet>..\..\..\stylecop.ruleset</CodeAnalysisRuleSet> | |||
| </PropertyGroup> | |||
| <Import Project="..\..\..\stylecop.props" /> | |||
|
|
|||
| <Target Name="ChangeAliasOfAkkaNet" BeforeTargets="FindReferenceAssembliesForReferences;ResolveReferences"> | |||
There was a problem hiding this comment.
Akka has some types which have the same name as the types we use elsewhere. So we need to quality the akka types with an alias.
There was a problem hiding this comment.
These should no longer be necessary since Akka.NET v1.4 - we were able to remove most of those type aliases now that we've moved onto .NET Standard 2.0.
philipktlin
reviewed
Mar 7, 2019
edge-agent/src/Microsoft.Azure.Devices.Edge.Agent.Core/logs/ILogsProcessor.cs
Show resolved
Hide resolved
philipktlin
reviewed
Mar 7, 2019
edge-agent/src/Microsoft.Azure.Devices.Edge.Agent.Core/logs/ILogsProcessor.cs
Outdated
Show resolved
Hide resolved
philipktlin
reviewed
Mar 7, 2019
edge-agent/src/Microsoft.Azure.Devices.Edge.Agent.Core/logs/LogMessageParser.cs
Outdated
Show resolved
Hide resolved
philipktlin
reviewed
Mar 7, 2019
edge-agent/src/Microsoft.Azure.Devices.Edge.Agent.Core/logs/LogMessageParser.cs
Show resolved
Hide resolved
varunpuranik
force-pushed
the
logsProvider
branch
from
5afdfae to
c0b5eea
Compare
myagley
previously approved these changes
Mar 12, 2019
edge-agent/src/Microsoft.Azure.Devices.Edge.Agent.Core/logs/ILogsProcessor.cs
Show resolved
Hide resolved
edge-agent/src/Microsoft.Azure.Devices.Edge.Agent.Core/logs/ILogsProcessor.cs
Outdated
Show resolved
Hide resolved
edge-agent/src/Microsoft.Azure.Devices.Edge.Agent.Core/logs/LogMessageParser.cs
Show resolved
Hide resolved
myagley
previously approved these changes
Mar 12, 2019
myagley
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a LogsProvider class that processes the logs obtained from iotedged, including deframing them, parsing them, compressing them, etc.
Next step will be to hook it all up to support uploading the logs/streaming the logs.