Tweak prepare_dns_san_entries for correctness, split out conversion of string to dns_label #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avranju
previously approved these changes
Jan 23, 2019
darobs
force-pushed
the
san_dns_tweaks
branch
from
e1f8053 to
8d015ad
Compare
avranju
approved these changes
Jan 23, 2019
mrohera
approved these changes
Jan 23, 2019
myagley
pushed a commit
to myagley/iotedge
that referenced
this pull request
Feb 4, 2019
myagley
added a commit
that referenced
this pull request
Feb 4, 2019
* Fix invalid DNS SAN entries (#795) Changes here fix a situation where a edge device's host name that begins with number(s) [0-9] gets sanitized. For example host name "2019edgehost" is consumed as "edgehost". This has caused problems was observed when using VMs that begin with numbers since it appears to be permitted configuration contrary to RFC 1035. The changes involve passing the configured host name as is into the SAN entry without any modifications. The module id DNS entry continues to be sanitized. * Revert "Fix invalid DNS SAN entries (#795)" This reverts commit a8148cc. * prepare_dns_san_entries was allowing characters that are not A-Za-z0-9 (#736) * Fix invalid DNS SAN entries (#795) Changes here fix a situation where a edge device's host name that begins with number(s) [0-9] gets sanitized. For example host name "2019edgehost" is consumed as "edgehost". This has caused problems was observed when using VMs that begin with numbers since it appears to be permitted configuration contrary to RFC 1035. The changes involve passing the configured host name as is into the SAN entry without any modifications. The module id DNS entry continues to be sanitized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepare_dns_san_entrieswas allowing characters that are not A-Za-z0-9 (see line 168).Plus, I need a function that just sanitizes a module name to a dns_label for my own nefarious purposes.