EdgeHub: Allow multiplexing client connections over AMQP #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myagley
previously approved these changes
Nov 30, 2018
edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Amqp/IConnectionHandler.cs
Outdated
Show resolved
Hide resolved
| // TODO: Temporary fix since SDK subscribes to C2D messages for modules. | ||
| if (string.IsNullOrWhiteSpace(this.ModuleId)) | ||
| { | ||
| await this.DeviceListener.AddSubscription(DeviceSubscription.C2D); |
There was a problem hiding this comment.
Is this not needed any more?
edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Amqp/linkhandlers/LinkHandlerProvider.cs
Show resolved
Hide resolved
Co-Authored-By: varunpuranik <[email protected]>
Co-Authored-By: varunpuranik <[email protected]>
varunpuranik
force-pushed
the
varunpuranik/amqpmux1
branch
from
be31116 to
c2a6d26
Compare
myagley
previously approved these changes
Nov 30, 2018
mrohera
approved these changes
Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still working on adding new tests.