EdgeHub: Resync service identity if client request cannot be authenticated #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myagley
previously approved these changes
Nov 26, 2018
| (isAuthenticated, valueFound) = await this.AuthenticateWithServiceIdentity(tCredentials, moduleIdentity.DeviceId, syncServiceIdentity); | ||
| } | ||
|
|
||
| return (isAuthenticated, !valueFound); |
There was a problem hiding this comment.
Can you add a comment about what these flags mean/are used for?
myagley
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, EdgeHub pulls service identities of devices/modules in scope and caches them locally. This cache is re-synced every hour (configurable).
If during this time, the client key was updated in IoTHub, the subsequent authentication will fail for the client if the client tried to connect to EdgeHub. To prevent this, if the authentication of an identity in scope fails locally, try to resync the identity with IoTHub and authenticate again.