Update functions binding runtime nuget package and update docker images for functions samples #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ancaantochi
commented
Oct 10, 2018
ancaantochi
commented
- Functions binding update to use the release webjobs nuget package
- Functions sample update to use functions docker images for 2.0
- Enable debug logs for functions in E2E deployment
ancaantochi
changed the title
damonbarry
approved these changes
Oct 10, 2018
|
|
||
| COPY samples/ samples/ | ||
| COPY . /app |
There was a problem hiding this comment.
Should we copy to /approot (and not set AzureWebJobsScriptRoot) here, to be consistent between Linux and Windows?
There was a problem hiding this comment.
In Linux container the default is value for AzureWebJobsScriptRoot is /home/site/wwwroot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.