Fix NRE in TwinManager #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myagley
commented
Sep 17, 2018
edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/TwinManager.cs
Outdated
Show resolved
Hide resolved
varunpuranik
approved these changes
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An NRE is possible in the TwinManager under the following sequence of events:
nullis used as a placeholder in the TwinManager when a reported property update is made with no twin. A get twin on this identity results innullbeing returned, which violates assumptions in the rest of the codebase.This was found via a failing CI test. The test case needed to be adjusted as well because of the changes for extended offline.